Add more #[\SensitiveParameter] #48274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fancyweb
commented
Nov 21, 2022
| @@ -79,7 +79,7 @@ public function getToken(string $tokenId): CsrfToken | |||
| return new CsrfToken($tokenId, $this->randomize($value)); | |||
| } | |||
|
|
|||
| public function refreshToken(#[\SensitiveParameter] string $tokenId): CsrfToken | |||
| public function refreshToken(string $tokenId): CsrfToken | |||
There was a problem hiding this comment.
@GromNaN I think this one was a mistake. It was not added to the interface and all other CSRF token ids. WDYT?
| @@ -28,7 +28,7 @@ public function getToken(string $tokenId): string; | |||
| /** | |||
| * Stores a CSRF token. | |||
| */ | |||
| public function setToken(string $tokenId, string $token); | |||
| public function setToken(string $tokenId, #[\SensitiveParameter] string $token); | |||
There was a problem hiding this comment.
From #46183:
The attribute has no effect on the interface, but is a remainder for implementers.
fabpot
approved these changes
Nov 22, 2022
|
Thank you @fancyweb. |
Merged
nicolas-grekas
added a commit
that referenced
this pull request
Jan 19, 2023
This PR was merged into the 6.3 branch. Discussion ---------- Add #[\SensitiveParameter] to $sessionId | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Follow-up to #48274 and #46183 Commits ------- 32c9f28 Add #[\SensitiveParameter] to $sessionId
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #46183