8000 [Form] Add better docs for `FormTypeExtensionInterface` by chr-hertel · Pull Request #48226 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Form] Add better docs for FormTypeExtensionInterface #48226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 19, 2022
Merged

[Form] Add better docs for FormTypeExtensionInterface #48226

merged 1 commit into from
Nov 19, 2022

Conversation

chr-hertel
Copy link
Contributor
Q A
Branch? 6.3
Bug fix? no
New feature? yes
Deprecations? no
License MIT

To be in sync with FormTypeInterface after #41869
Basically for PHPStan

@carsonbot carsonbot added this to the 6.2 milestone Nov 16, 2022
@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "6.2" but it seems your PR description refers to branch "6.3".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@OskarStark
Copy link
Contributor

#41869 was merged into 4.4 branch, what about this one?

@OskarStark OskarStark changed the title [Form] Add better docs for FormTypeExtensionInterface [Form] Add better docs for FormTypeExtensionInterface Nov 17, 2022
@chr-hertel
Copy link
Contributor Author

@OskarStark wasn't sure about this, but totally fine by me. Rebase is easy here :)

@OskarStark
Copy link
Contributor

friendly ping @nicolas-grekas

@fabpot
Copy link
Member
fabpot commented Nov 19, 2022

That's the kind of changes we used to do in lower branches, but not anymore. I'm going to merge it in 6.2.

@fabpot
Copy link
Member
fabpot commented Nov 19, 2022

Thank you @chr-hertel.

@fabpot fabpot merged commit ececb2a into symfony:6.2 Nov 19, 2022
@chr-hertel chr-hertel deleted the form-type-extension-docs branch November 19, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof approved these changes

@OskarStark OskarStark OskarStark approved these changes

@xabbuh xabbuh xabbuh approved these changes

@yceruto yceruto yceruto approved these changes

@maxbeckers maxbeckers maxbeckers approved these changes

Assignees
No one assigned
Labels
Feature Form Status: Reviewed
Projects
None yet
Milestone
6.2
Development

Successfully merging this pull request may close these issues.
8 participants
@chr-hertel @carsonbot @OskarStark @fabpot @stof @xabbuh @yceruto @maxbeckers
0