[Security] Improve LogoutUrlGenerator exception message
#48212
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Thanks for your PR. You are targeting branch "6.2" but it seems your PR description refers to branch "6.3". Cheers! Carsonbot |
wouterj
requested changes
Nov 16, 2022
src/Symfony/Component/Security/Http/Logout/LogoutUrlGenerator.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Security/Http/Logout/LogoutUrlGenerator.php
Outdated
Show resolved
Hide resolved
|
I'm ok with these new messages @wouterj, PR updated |
chalasr
approved these changes
Nov 18, 2022
LogoutUrlGenerator exception message
wouterj
approved these changes
Nov 18, 2022
wouterj
reviewed
Nov 18, 2022
src/Symfony/Component/Security/Http/Logout/LogoutUrlGenerator.php
Outdated
Show resolved
Hide resolved
|
Thank you @alamirault. |
fabpot
added a commit
that referenced
this pull request
Nov 19, 2022
…e (alamirault) This PR was squashed before being merged into the 6.2 branch. Discussion ---------- [Security] Improve `LogoutUrlGenerator` exception message | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | yes <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | Fix #45913 <!-- prefix each issue number with "Fix #", no need to create an issue if none exists, explain below instead --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> With this PR, exception message is different when request is under firewall or not, as suggested in #45913 (comment) Commits ------- 59187f2 [Security] Improve `LogoutUrlGenerator` exception message
a0eb08f to
59187f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, exception message is different when request is under firewall or not, as suggested in #45913 (comment)