[WebProfilerBundle] Remove redundant code from logger template #48046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! I think @Amunak has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
Member
|
@javiereguiluz Can you have a look? |
javiereguiluz
approved these changes
Nov 30, 2022
Member
There was a problem hiding this comment.
Sorry I missed this. Thanks for fixing this issue!
stof
approved these changes
Nov 30, 2022
maxhelias
approved these changes
Dec 1, 2022
fabpot
approved these changes
Dec 1, 2022
Member
|
Thank you @HypeMC. |
Merged
This was referenced Dec 28, 2022
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3C6B
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced in #42195, the log trace gets unnecessarily rendered twice: