8000 Shorten Placeholder for Search input by PhilETaylor · Pull Request #48001 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Shorten Placeholder for Search input #48001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 27, 2022
Merged

Shorten Placeholder for Search input #48001

merged 1 commit into from
Oct 27, 2022

Conversation

PhilETaylor
Copy link
Contributor
Q A
Branch? 6.2
Bug fix? yes
New feature? no
Deprecations? no
License MIT

Even on a stupidly large screen, the "Search on Symfony.com" input box has a placeholder that is truncated to search on symfony.co (missing final m)

Symfony.co is not a valid or owned official domain.

Screenshot is Safari, Google Chrome, Firefox. Firefox is the only one that renders the full placeholder.

Screenshot 2022-10-26 at 11 37 35

Proposing to remove the word on so that the placeholder is just search symfony.com

@carsonbot carsonbot added this to the 6.2 milestone Oct 26, 2022
@javiereguiluz
Copy link
Member

Instead of this, could you please try to increase a bit the input size here:

symfony/src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/profiler.css.twig

Line 1021 in 3b4cda1

width: 200px;

Thanks.

@PhilETaylor
Copy link
Contributor Author
PhilETaylor commented Oct 26, 2022 •
edited
Loading

yup, 215px works.

Screenshot 2022-10-26 at 13 59 44

210px is still clipping

Screenshot 2022-10-26 at 13 58 43

@javiereguiluz
Copy link
Member

@PhilETaylor if you can, please update this PR to keep the original text but apply the longer width. Thanks.

@PhilETaylor
Copy link
Contributor Author

yes sorry - School is out and kid had dentist, will do that now :)

@PhilETaylor
Copy link
Contributor Author

@javiereguiluz Done :)

@PhilETaylor
Copy link
Contributor Author

Failing tests are not my fault :) honest :-)

@PhilETaylor PhilETaylor changed the title Shorten Placeholder for Search input [WebProfilerBundle] Shorten Placeholder for Search input Oct 26, 2022
@carsonbot carsonbot changed the title [WebProfilerBundle] Shorten Placeholder for Search input Shorten Placeholder for Search input Oct 26, 2022
@fabpot
Copy link
Member
fabpot commented Oct 27, 2022

Good catch, thanks @PhilETaylor.

@fabpot fabpot merged commit 44a6e66 into symfony:6.2 Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@OskarStark OskarStark OskarStark approved these changes

Assignees
No one assigned
Labels
Bug Status: Reviewed
Projects
None yet
Milestone
6.2
Development

Successfully merging this pull request may close these issues.
5 participants
@PhilETaylor @javiereguiluz @fabpot @OskarStark @carsonbot
0