8000 [Translation] translation:push command diff using intl-icu by Broutard · Pull Request #47986 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Translation] translation:push command diff using intl-icu #47986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

[Translation] translation:push command diff using intl-icu #47986

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a699db1
[Translation] translation:push command diff using intl-icu
Broutard Oct 25, 2022
8cd9a0a
fix pull/push
Broutard Nov 10, 2022
ee05664
add test
Broutard Nov 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
[Translation] translation:push command diff using intl-icu
  • Loading branch information
@Broutard
Broutard committed Oct 25, 2022
commit a699db181f53d9aaf4187db0deb71849523796b3
2 changes: 1 addition & 1 deletion src/Symfony/Component/Translation/Command/TranslationTrait.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ private function filterCatalogue(MessageCatalogue $catalogue, string $domain): M
// extract intl-icu messages only
$intlDomain = $domain.MessageCatalogueInterface::INTL_DOMAIN_SUFFIX;
if ($intlMessages = $catalogue->all($intlDomain)) {
$filteredCatalogue->add($intlMessages, $intlDomain);
$filteredCatalogue->add($intlMessages, $domain);
}

// extract all messages and subtract intl-icu messages
Expand Down
0