8000 [Asset] improve performance of `UrlPackage::chooseBaseUrl()` by kbond · Pull Request #47903 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Asset] improve performance of UrlPackage::chooseBaseUrl() #47903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2022
Merged

[Asset] improve performance of UrlPackage::chooseBaseUrl() #47903

merged 1 commit into from
Oct 20, 2022

Conversation

kbond
Copy link
Member
@kbond kbond commented Oct 18, 2022 •
edited
Loading
Q A
Branch? 6.2
Bug fix? no
New feature? no
Deprecations? no
Tickets n/a
License MIT
Doc PR n/a

@frankdejonge discovered this performance improvement when implementing a similar feature in flysystem (thephpleague/flysystem#1570). A simple benchmark by me indicated it was 3-4x faster.

Note: Sites using this feature that have assets heavily cached would now have a different distribution.

@carsonbot carsonbot added this to the 6.2 milestone Oct 18, 2022
@kbond kbond force-pushed the asset-base-url-perf branch from e501f64 to 428ee4d Compare October 18, 2022 21:41
nicolas-grekas
nicolas-grekas reviewed Oct 19, 2022
View reviewed changes
@kbond @frankdejonge
[Asset] improve performance of UrlPackage::chooseBaseUrl()
35dff8f 
Co-authored-by: Frank de Jonge <frankdejonge@users.noreply.github.com>
@kbond kbond force-pushed the asset-base-url-perf branch from 428ee4d to 35dff8f Compare October 19, 2022 16:13
@fabpot
Copy link
Member
fabpot commented Oct 20, 2022

Thank you @kbond.

@fabpot fabpot merged commit 0de91ed into symfony:6.2 Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@frankdejonge frankdejonge frankdejonge left review comments

@fabpot fabpot fabpot approved these changes

@stof stof stof approved these changes

Assignees
No one assigned
Labels
Asset Status: Reviewed
Projects
None yet
Milestone
6.2
Development

Successfully merging this pull request may close these issues.
6 participants
@kbond @fabpot @nicolas-grekas @stof @frankdejonge @carsonbot
0