8000 [HttpKernel] Fix empty request stack when terminating with exception by krzyc · Pull Request #47857 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[HttpKernel] Fix empty request stack when terminating with exception #47857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 18, 2022
Merged

[HttpKernel] Fix empty request stack when terminating with exception #47857

merged 1 commit into from
Oct 18, 2022

Conversation

krzyc
Copy link
Contributor
@krzyc krzyc commented Oct 13, 2022
Q A
Branch? 4.4, 5.4, 6.0, 6.1, 6.2
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #47577
License MIT
Doc PR

After #47358 the RequestStack is empty when request terminates with exception, which prevents SecurityDataCollector to generate logout URL and generates fatal error.

@carsonbot carsonbot added this to the 4.4 milestone Oct 13, 2022
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

stof
stof requested changes Oct 13, 2022
View reviewed changes
@krzyc krzyc requested a review from stof October 13, 2022 16:31
@VincentLanglet
Copy link
Contributor
VincentLanglet commented Oct 18, 2022 •
edited
Loading

I got the issue locally (on SF 6.1) and I can confirm this PR is fixing the issue.

nicolas-grekas
nicolas-grekas approved these changes Oct 18, 2022
View reviewed changes
Copy link
Member
@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a check to make the logic work in case of re-injected fatal errors (which means the request won't have had the opportunity to be popped)

@nicolas-grekas
Copy link
Member

Thank you @krzyc.

@nicolas-grekas nicolas-grekas merged commit dffff8e into symfony:4.4 Oct 18, 2022
This was referenced Oct 18, 2022
Closed
Closed
Closed
This was referenced Oct 26, 2022
Closed
Merged
This was referenced Oct 28, 2022
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@stof stof Awaiting requested review from stof

Assignees
No one assigned
Labels
Bug HttpKernel Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@krzyc @carsonbot @VincentLanglet @nicolas-grekas @stof
0