8000 Norgweiang translations by ibonkonesa · Pull Request #47751 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

Norgweiang translations #47751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2022
Merged

Conversation

ibonkonesa
Copy link
Contributor
Q A
Branch? 6.2 for features / 4.4, 5.4, 6.0 or 6.1 for bug fixes
Bug fix? yes/no
New feature? yes/no
Deprecations? yes/no
Tickets Fix #...
License MIT
Doc PR symfony/symfony-docs#...

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@fabpot
Copy link
Member
fabpot commented Oct 1, 2022

Thank you @ibonkonesa.

@fabpot fabpot merged commit 70e0b99 into symfony:6.2 Oct 1, 2022
xabbuh pushed a commit that referenced this pull request Oct 1, 2022
This PR was merged into the 6.2 branch.

Discussion
----------

Norgweiang translations

| Q             | A
| ------------- | ---
| Branch?       | 6.2 for features / 4.4, 5.4, 6.0 or 6.1 for bug fixes <!-- see below -->
| Bug fix?      | yes/no
| New feature?  | yes/no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | yes/no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->
<!--
Replace this notice by a short README for your feature/bugfix.
This will help reviewers and should be a good start for the documentation.

Additionally (see https://symfony.com/releases):
 - Always add tests and ensure they pass.
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the latest branch.
 - For new features, provide some code snippets to help understand usage.
 - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry
 - Never break backward compatibility (see https://symfony.com/bc).
-->

Commits
-------

b6998ed Norgweiang translations
xabbuh added a commit that referenced this pull request Oct 1, 2022
* 4.4:
  skip a test if the mime type detection feature will not work
  minor #47751 Norgweiang translations (ibonkonesa)
  fix overflow issue in WebPprofiler Forms panel
xabbuh added a commit that referenced this pull request Oct 2, 2022
* 5.4:
  sync message serializer code for forward-compatibility
  skip a test if the mime type detection feature will not work
  minor #47751 Norgweiang translations (ibonkonesa)
  fix overflow issue in WebPprofiler Forms panel
xabbuh added a commit that referenced this pull request Oct 2, 2022
* 6.0:
  sync message serializer code for forward-compatibility
  skip a test if the mime type detection feature will not work
  minor #47751 Norgweiang translations (ibonkonesa)
  fix overflow issue in WebPprofiler Forms panel
xabbuh added a commit that referenced this pull request Oct 2, 2022
* 6.1:
  sync message serializer code for forward-compatibility
  skip a test if the mime type detection feature will not work
  minor #47751 Norgweiang translations (ibonkonesa)
  fix overflow issue in WebPprofiler Forms panel
Sign up for free to join this conversation on GitHub. Already have an account? Sign i 786C n to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0