10000 [TwigBridge] Avoid double render when an exception is thrown in !debug by lyrixx · Pull Request #47733 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[TwigBridge] Avoid double render when an exception is thrown in !debug #47733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 7, 2022
Merged

[TwigBridge] Avoid double render when an exception is thrown in !debug #47733

merged 1 commit into from
Oct 7, 2022

Conversation

lyrixx
Copy link
Member
@lyrixx lyrixx commented Sep 29, 2022
Q A
Branch? 6.2
Bug fix? no
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

In !debug, the error is rendered a first time in TwigErrorRenderer::render()
via $exception = $this->fallbackErrorRenderer->render($exception); But
in !debug, the error is rendered another time with twig.

@lyrixx lyrixx requested a review from yceruto as a code owner September 29, 2022 15:57
@carsonbot carsonbot added this to the 6.2 milestone Sep 29, 2022
stof
stof requested changes Sep 29, 2022
View reviewed changes
@lyrixx lyrixx force-pushed the error-avoid-doubler-render branch from 9e6863f to f778a83 Compare September 30, 2022 08:47
@lyrixx lyrixx requested a review from stof September 30, 2022 08:48
yceruto
yceruto reviewed Sep 30, 2022
View reviewed changes
@lyrixx lyrixx force-pushed the error-avoid-doubler-render branch from f778a83 to 7924624 Compare October 7, 2022 08:32
@lyrixx lyrixx force-pushed the error-avoid-doubler-render branch from 7924624 to 301c53b Compare October 7, 2022 08:33
@fabpot
Copy link
Member
fabpot commented Oct 7, 2022

Thank you @lyrixx.

@fabpot fabpot merged commit c2af1fd into symfony:6.2 Oct 7, 2022
@lyrixx lyrixx deleted the error-avoid-doubler-render branch October 7, 2022 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yceruto yceruto yceruto left review comments

@fabpot fabpot fabpot approved these changes

@stof stof stof approved these changes

Assignees
No one assigned
Labels
Status: Reviewed TwigBridge
Projects
None yet
Milestone
6.2
Development

Successfully merging this pull request may close these issues.
5 participants
@lyrixx @fabpot @stof @yceruto @carsonbot
0