8000 [Form] Fixed FormBuilder to maintain order of its children by webmozart · Pull Request #4772 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Form] Fixed FormBuilder to maintain order of its children #4772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 6, 2012
Merged

[Form] Fixed FormBuilder to maintain order of its children #4772

merged 1 commit into from
Jul 6, 2012

Conversation

webmozart
Copy link
Contributor

Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: #4693
Todo: -

fabpot added a commit that referenced this pull request Jul 6, 2012
@fabpot
merged branch bschussek/issue4693 (PR #4772)
0a3436d 
Commits
-------

d6e1f39 [Form] Fixed FormBuilder to maintain order of its children

Discussion
----------

[Form] Fixed FormBuilder to maintain order of its children

Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: #4693
Todo: -
@fabpot fabpot merged commit d6e1f39 into symfony:master Jul 6, 2012
@fabpot
Copy link
Member
fabpot commented Jul 6, 2012

This PR breaks the tests: http://travis-ci.org/#!/symfony/symfony/jobs/1796369

@webmozart
Copy link
Contributor Author

Sorry, going to fix this. Why doesn't the Travis CI bot run anymore for the PRs?

@fabpot
Copy link
Member
fabpot commented Jul 8, 2012

I have no idea why Travis stopped working on PRs.

@stof
Copy link
Member
stof commented Jul 8, 2012

This is weird. It works for the Doctrine ORM repo.

@webmozart
Copy link
Contributor Author

Fixed in #4787

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Form
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.
3 participants
@webmozart @fabpot @stof
0