8000 [Mailer][Mailjet] Apply the default value of 512 for max depths by nurtext · Pull Request #47703 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Mailer][Mailjet] Apply the default value of 512 for max depths #47703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 29, 2022
Merged

[Mailer][Mailjet] Apply the default value of 512 for max depths #47703

merged 1 commit into from
Sep 29, 2022

Conversation

nurtext
Copy link
Contributor
@nurtext nurtext commented Sep 27, 2022
Q A
Branch? 6.1
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #47701
License MIT
Doc PR n/a

Applies the default value of 512 for max depths when using PHP's json_decode() function.

See #47701 for more details.

@carsonbot carsonbot added this to the 6.2 milestone Sep 27, 2022
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@nurtext nurtext changed the base branch from 6.2 to 6.1 September 27, 2022 11:19
@carsonbot carsonbot changed the title [symfony/mailjet-mailer] Fix bug #47701 [Mailer] [symfony/mailjet-mailer] Fix bug #47701 Sep 29, 2022
@OskarStark OskarStark changed the title [Mailer] [symfony/mailjet-mailer] Fix bug #47701 [Mailer][Mailjet] Fix bug #47701 Sep 29, 2022
@OskarStark OskarStark changed the title [Mailer][Mailjet] Fix bug #47701 [Mailer][Mailjet] Applies the default value of 512 for max depths Sep 29, 2022
@OskarStark
Copy link
Contributor

I would consider this a bugfix to be merged in 6.1 instead of 6.2

@OskarStark OskarStark changed the title [Mailer][Mailjet] Applies the default value of 512 for max depths [Mailer][Mailjet] Apply the default value of 512 for max depths Sep 29, 2022
@fabpot fabpot modified the milestones: 6.2, 6.0, 6.1 Sep 29, 2022
@fabpot
Copy link
Member
fabpot commented Sep 29, 2022

Thank you @nurtext.

@fabpot fabpot merged commit 3810eaa into symfony:6.1 Sep 29, 2022
@fabpot fabpot mentioned this pull request Sep 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@OskarStark OskarStark OskarStark approved these changes

Assignees
No one assigned
Labels
Bug Mailer Status: Reviewed
Projects
None yet
Milestone
6.1
Development

Successfully merging this pull request may close these issues.

[symfony/mailjet-mailer] JSON payload for X-MJ-Vars only allows for a max depth of two (2)
4 participants
@nurtext @carsonbot @OskarStark @fabpot
0