8000 remove no longer needed PHP version requirements from tests by xabbuh · Pull Request #47606 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

remove no longer needed PHP version requirements from tests #47606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2022
Merged

remove no longer needed PHP version requirements from tests #47606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions ...mfony/Component/DependencyInjection/Tests/Compiler/RegisterServiceSubscribersPassTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,9 +131,6 @@ public function testWithAttributes()
$this->assertEquals($expected, $container->getDefinition((string) $locator->getFactory()[0])->getArgument(0));
}

/**
* @requires PHP 8
*/
public function testUnionServices()
{
$container = new ContainerBuilder();
Expand Down Expand Up @@ -310,9 +307,6 @@ public function method()
$subscriber::getSubscribedServices();
}

/**
* @requires PHP 8
*/
public function testServiceSubscriberTraitWithUnionReturnType()
{
if (!class_exists(SubscribedService::class)) {
Expand Down
6 changes: 0 additions & 6 deletions src/Symfony/Component/Messenger/Tests/DependencyInjection/MessengerPassTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,9 +540,6 @@ public function testBuiltinArgumentTypeHandler()
(new MessengerPass())->process($container);
}

/**
* @requires PHP 8
*/
public function testUnionTypeArgumentsTypeHandler()
{
$container = $this->getContainerBuilder($busId = 'message_bus');
Expand All @@ -561,9 +558,6 @@ public function testUnionTypeArgumentsTypeHandler()
$this->assertHandlerDescriptor($container, $handlersMapping, DummyMessage::class, [UnionTypeArgumentHandler::class]);
}

/**
* @requires PHP 8
*/
public function testUnionBuiltinArgumentTypeHandler()
{
$this->expectException(RuntimeException::class);
Expand Down
3 changes: 0 additions & 3 deletions src/Symfony/Component/Validator/Tests/Constraints/ValidTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,6 @@ public function testGroupsAreNullByDefault()
$this->assertNull($constraint->groups);
}

/**
* @requires PHP 8
*/
public function testAttributes()
{
$metadata = new ClassMetaData(ValidDummy::class);
Expand Down
0