8000 [FrameworkBundle] Deprecate "legacy_error_messages" form config node by HeahDude · Pull Request #47598 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[FrameworkBundle] Deprecate "legacy_error_messages" form config node #47598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 18, 2022
Merged

[FrameworkBundle] Deprecate "legacy_error_messages" form config node #47598

merged 1 commit into from
Sep 18, 2022

Conversation

HeahDude
Copy link
Contributor
Q A
Branch? 6.2
Bug fix? no
New feature? no
Deprecations? yes
Tickets ~
License MIT
Doc PR ~

@carsonbot carsonbot added this to the 6.2 milestone Sep 16, 2022
@HeahDude HeahDude force-pushed the feat/deprecate-form-legacy_error_messages-config branch from 9bb6dca to f890fb9 Compare September 16, 2022 15:13
@fabpot
Copy link
Member
fabpot commented Sep 17, 2022

But tests should be fixed.

@HeahDude HeahDude force-pushed the feat/deprecate-form-legacy_error_messages-config branch from f890fb9 to bfcc49a Compare September 18, 2022 06:47
@HeahDude
Copy link
Contributor Author

@fabpot it's ok now :).

@fabpot
Copy link
Member
fabpot commented Sep 18, 2022

Good catch, thanks @HeahDude.

@fabpot fabpot merged commit f951250 into symfony:6.2 Sep 18, 2022
@HeahDude HeahDude deleted the feat/deprecate-form-legacy_error_messages-config branch September 18, 2022 08:02
@manuelkiessling manuelkiessling mentioned this pull request Nov 29, 2022
Merged
OskarStark added a commit to symfony/symfony-docs that referenced this pull request Dec 9, 2022
@OskarStark
minor #17478 [Form] Remove paragraph on legacy_error_messages confi…
ac50348 
…g (manuelkiessling)

This PR was merged into the 6.2 branch.

Discussion
----------

[Form] Remove paragraph on `legacy_error_messages` config

As the `legacy_error_messages` config node is deprecated since 6.2 (see symfony/symfony#47598), it should probably not be mentioned in the docs any longer.

Commits
-------

50bfc31 Remove paragraph on legacy_error_messages config
@MrYamous MrYamous mentioned this pull request Sep 24, 2024
Merged
javiereguiluz added a commit to symfony/symfony-docs that referenced this pull request Sep 25, 2024
@javiereguiluz
minor #20250 [Form] Remove legacy message (MrYamous)
a485b67 
This PR was merged into the 7.1 branch.

Discussion
----------

[Form] Remove legacy message

IIUC what happened with #17478 and [related code PR](symfony/symfony#47598), legacy invalid message refer to something which no longer exists

Commits
-------

6516a9b form/remove-legacy-message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@stof stof stof approved these changes

Assignees
No one assigned
Labels
Deprecation FrameworkBundle Status: Reviewed
Projects
None yet
Milestone
6.2
Development

Successfully merging this pull request may close these issues.
4 participants
@HeahDude @fabpot @stof @carsonbot
0