8000 Remove `size` FormView variable by mpdude · Pull Request #47522 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Remove size FormView variable #47522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 9, 2022
Merged

Remove size FormView variable #47522

merged 1 commit into from
Sep 9, 2022

Conversation

mpdude
Copy link
Contributor
@mpdude mpdude commented Sep 8, 2022 •
edited
Loading
Q A
Branch? 6.2
Bug fix? no
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

While adding FormView::$vars support in the Psalm Plugin for Symfony, I came across the size key.

I tried to figure out the meaning of the setting, but it is not documented, seems to be used nowhere, and has been around since the early days of the Form Component a decade ago.

So, my assumption is that is has no meaning/relevance and thus my suggestion is to remove it.

@carsonbot carsonbot added this to the 6.2 milestone Sep 8, 2022
@fabpot
Copy link
Member
fabpot commented Sep 9, 2022

Thank you @mpdude.

@fabpot fabpot merged commit 2a32835 into symfony:6.2 Sep 9, 2022
@mpdude mpdude deleted the patch-5 branch September 9, 2022 11:08
@xabbuh
Copy link
Member
xabbuh commented Sep 9, 2022

Technically that’s a BC break, right? Should we trigger a deprecation?

@stof
Copy link
Member
stof commented Sep 9, 2022

I don't think we we trigger a deprecation when accessing a Twig variable. And this variable has been null-only since the introduction of the Form component. It has never been assigned a non-null value in a released version of Symfony.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@stof stof stof approved these changes

@yceruto yceruto yceruto approved these changes

@xabbuh xabbuh Awaiting requested review from xabbuh xabbuh is a code owner

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
6.2
Development

Successfully merging this pull request may close these issues.
6 participants
@mpdude @fabpot @xabbuh @stof @yceruto @carsonbot
0