8000 [HttpKernel] Make Logger implement DebugLoggerInterface by MatTheCat · Pull Request #47483 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[HttpKernel] Make Logger implement DebugLoggerInterface #47483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2022
Merged

[HttpKernel] Make Logger implement DebugLoggerInterface #47483

merged 1 commit into from
Oct 20, 2022

Conversation

@MatTheCat
Copy link
Contributor
@MatTheCat MatTheCat commented Sep 4, 2022
Q A
Branch? 6.2
Bug fix? no
New feature? yes
Deprecations? no
Tickets N/A
License MIT
Doc PR N/A

When starting a new project from a skeleton I was surprised not to see any log in the profiler and error pages. Turns out this depends of the logger implementing DebugLoggerInterface but AFAIK this only happen in Monolog’s bridge.

Given the API makes it weird to implement it in userland (see #47396) would it make sense to provide one by default?

@MatTheCat MatTheCat requested a review from dunglas as a code owner September 4, 2022 12:46
@carsonbot carsonbot added Status: Needs Review Feature HttpKernel RFC RFC = Request For Comments (proposals about features that you want to be discussed) labels Sep 4, 2022
@carsonbot carsonbot added this to the 6.2 milestone Sep 4, 2022
@carsonbot carsonbot changed the title [RFC][HttpKernel] Make Logger implement DebugLoggerInterface [HttpKernel] Make Logger implement DebugLoggerInterface Sep 4, 2022
nicolas-grekas
nicolas-grekas reviewed Sep 12, 2022
View reviewed changes
lyrixx
lyrixx reviewed Sep 13, 2022
View reviewed changes
@MatTheCat MatTheCat force-pushed the debug_logger branch 2 times, most recently from aaf7197 to 438b512 Compare September 14, 2022 15:11
@MatTheCat
Copy link
Contributor Author
MatTheCat commented Sep 14, 2022 •
edited
Loading

Thanks for your feedback 🙏

I updated the PR accordingly.

@MatTheCat MatTheCat force-pushed the debug_logger branch 3 times, most recently from d59e2fb to 9a9cc67 Compare September 21, 2022 16:04
MatTheCat added a commit to MatTheCat/symfony that referenced this pull request Oct 17, 2022
@MatTheCat
Address symfony#47483 (comment)
c1a66d6
nicolas-grekas
nicolas-grekas reviewed Oct 17, 2022
View reviewed changes
MatTheCat added a commit to MatTheCat/symfony that referenced this pull request Oct 17, 2022
@MatTheCat
Address symfony#47483 (comment)
910aa73
MatTheCat added a commit to MatTheCat/symfony that referenced this pull request Oct 17, 2022
@MatTheCat
Address symfony#47483 (review)
83bae94
MatTheCat added a commit to MatTheCat/symfony that referenced this pull request Oct 17, 2022
@MatTheCat
Address symfony#47483 (comment)
bb4db68
MatTheCat added a commit to MatTheCat/symfony that referenced this pull request Oct 17, 2022
@MatTheCat
Address symfony#47483 (comment)
66982e0
@nicolas-grekas nicolas-grekas added the ❄️ Feature Freeze Important Pull Requests to finish before the next Symfony "feature freeze" label Oct 19, 2022
@fabpot
Copy link
Member
fabpot commented Oct 20, 2022

Thank you @MatTheCat.

@fabpot fabpot mentioned this pull request Oct 20, 2022
Closed
@fabpot fabpot merged commit 651b465 into symfony:6.2 Oct 20, 2022
@MatTheCat MatTheCat deleted the debug_logger branch October 20, 2022 12:41
@fabpot fabpot mentioned this pull request Oct 24, 2022
Merged
@MatTheCat MatTheCat mentioned this pull request Oct 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lyrixx lyrixx lyrixx left review comments

@derrabus derrabus derrabus left review comments

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

+1 more reviewer

@ro0NL ro0NL ro0NL left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Feature HttpKernel RFC RFC = Request For Comments (proposals about features that you want to be discussed) ❄️ Feature Freeze Important Pull Requests to finish before the next Symfony "feature freeze" Status: Reviewed

Projects

None yet

Milestone

6.2

Development

Successfully merging this pull request may close these issues.

7 participants

@MatTheCat @fabpot @nicolas-grekas @lyrixx @ro0NL @derrabus @carsonbot
0