8000 [FrameworkBundle] Do not throw when describing a factory definition by MatTheCat · Pull Request #47351 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[FrameworkBundle] Do not throw when describing a factory definition #47351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2022
Merged

[FrameworkBundle] Do not throw when describing a factory definition #47351

merged 1 commit into from
Aug 30, 2022

Conversation

MatTheCat
Copy link
Contributor
Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #47309
License MIT
Doc PR N/A

@carsonbot carsonbot added this to the 4.4 milestone Aug 21, 2022
@nicolas-grekas
Copy link
Member

Thank you @MatTheCat.

@nicolas-grekas nicolas-grekas merged commit ee9df24 into symfony:4.4 Aug 30, 2022
@MatTheCat MatTheCat deleted the ticket_47309 branch August 30, 2022 16:42
@xabbuh xabbuh mentioned this pull request Sep 2, 2022
Merged
fabpot added a commit that referenced this pull request Sep 2, 2022
@fabpot
minor #47469 [FrameworkBundle] tweak the factory class description fo…
6648b82 
…r inlined factory services (xabbuh)

This PR was merged into the 4.4 branch.

Discussion
----------

[FrameworkBundle] tweak the factory class description for inlined factory services

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #47351 (comment)
| License       | MIT
| Doc PR        |

Commits
-------

5f0a5b4 tweak the factory class description for inlined factory services
This was referenced Sep 30, 2022
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof left review comments

@xabbuh xabbuh xabbuh left review comments

Assignees
No one assigned
Labels
Bug FrameworkBundle Status: Needs Review
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@MatTheCat @nicolas-grekas @stof @xabbuh @carsonbot
0