[FrameworkBundle] execute tests with the full range of supported Messenger component releases #47232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
023514f to
1bc150f
Compare
…leases The conflict rule does not exclude the 5.4 and 6.0 releases of the Messenger component. So we should make sure that we also run tests against these versions.
1bc150f to
e912f85
Compare
xabbuh
commented
Aug 9, 2022
| if (isset($tagAttributes['method'])) { | ||
| throw new LogicException(sprintf('AsMessageHandler attribute cannot declare a method on "%s::%s()".', $reflector->class, $reflector->name)); | ||
|
|
||
| if (class_exists(SerializedMessageStamp::class)) { |
There was a problem hiding this comment.
alternatively, we would have to conflict with symfony/messenger before 6.1
There was a problem hiding this comment.
As 6.1 is already released, I think having a condition is ok. On 6.2, we can then remove the condition and add a conflict.
There was a problem hiding this comment.
That was my reasoning too for choosing this solution. Will be simplified on 6.2 with #47237.
fabpot
approved these changes
Aug 9, 2022
| if (isset($tagAttributes['method'])) { | ||
| throw new LogicException(sprintf('AsMessageHandler attribute cannot declare a method on "%s::%s()".', $reflector->class, $reflector->name)); | ||
|
|
||
| if (class_exists(SerializedMessageStamp::class)) { |
There was a problem hiding this comment.
As 6.1 is already released, I think having a condition is ok. On 6.2, we can then remove the condition and add a conflict.
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Aug 10, 2022
…(xabbuh) This PR was merged into the 6.2 branch. Discussion ---------- [FrameworkBundle] conflict with symfony/messenger < 6.2 | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | #47232 (comment) | License | MIT | Doc PR | Commits ------- 4d6f215 conflict with symfony/messenger < 6.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The conflict rule does not exclude the 5.4 and 6.0 releases of the Messenger component. So we should make sure that we also run tests against these versions.