10000 [Messenger] Support for custom handler method containing a Union type tagged with #[AsMessageHandler] by ArchitectNate · Pull Request #47227 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Messenger] Support for custom handler method containing a Union type tagged with #[AsMessageHandler] #47227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 13, 2022
Merged

[Messenger] Support for custom handler method containing a Union type tagged with #[AsMessageHandler] #47227

merged 1 commit into from
Sep 13, 2022

Conversation

ArchitectNate
Copy link
Contributor
Q A
Branch? 6.1
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #47206
License MIT
Doc PR No

When Union Types were implemented for the #[AsMessageHandler] attribute, it wasn't designed with non __invoke methods in mind.

This fix detects if we are using __invoke or not and constructs the return to match the rest of the logic, mainly it allows for a type => methodName map if __invoke is not being used.

@carsonbot carsonbot added this to the 6.1 milestone Aug 9, 2022
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@ArchitectNate
Copy link
Contributor Author

For the unit test, I tried to reuse the messages that were there but ultimately had to create new dummy messages. Let me know if I need to adjust any of these semantic things

@ArchitectNate ArchitectNate changed the title [Messenger] Support for custom handler method using #[AsMessageHandler] containing a Union type [Messenger] Support for custom handler method containing a Union type tagged with #[AsMessageHandler] Aug 9, 2022
@magikid
Copy link
Contributor
magikid commented Aug 17, 2022

@carsonbot find me a reviewer please

@carsonbot
Copy link

@angelov could maybe review this PR?

@ArchitectNate
Copy link
Contributor Author

@carsonbot find me a reviewer please

@carsonbot
Copy link

@monteiro could maybe review this PR?

@klaussilveira
Copy link
Contributor

Oh, this is useful. 👍

@xabbuh
Copy link
Member
xabbuh commented Sep 10, 2022 •
edited
Loading

For 5.4? (nope, support for adding the #AsMessageHandler attribute to methods was only introduced in #45273 in 6.1(

@xabbuh xabbuh modified the milestones: 6.1, 5.4 Sep 10, 2022
@fabpot
Copy link
Member
fabpot commented Sep 13, 2022

Thank you @ArchitectNate.

@fabpot fabpot merged commit d6bde21 into symfony:6.1 Sep 13, 2022
@fabpot fabpot mentioned this pull request Sep 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Bug Messenger Status: Reviewed
Projects
None yet
Milestone
6.1
Development

Successfully merging this pull request may close these issues.
6 participants
@ArchitectNate @carsonbot @magikid @klaussilveira @xabbuh @fabpot
0