8000 [Validator] validate nested constraints only if they are in the same group by xabbuh · Pull Request #47211 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Validator] validate nested constraints only if they are in the same group #47211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 9, 2022
Merged

[Validator] validate nested constraints only if they are in the same group #47211

merged 1 commit into from
Aug 9, 2022

Conversation

xabbuh
Copy link
Member
@xabbuh xabbuh commented Aug 6, 2022
Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #46638
License MIT
Doc PR

@xabbuh xabbuh added this to the 5.4 milestone Aug 6, 2022
@xabbuh xabbuh mentioned this pull request Aug 6, 2022
Closed
@fabpot
Copy link
Member
fabpot commented Aug 9, 2022

Are the test broken by this PR?

@xabbuh
Copy link
Member Author
xabbuh commented Aug 9, 2022

I'm gonna check.

@fabpot
Copy link
Member
fabpot commented Aug 9, 2022

fabbot issue should be fixed IMO.

@xabbuh
Copy link
Member Author
xabbuh commented Aug 9, 2022

Are the test broken by this PR?

I rebased, the tests were actually already fixed before by #47203

@fabpot
Copy link
Member
fabpot commented Aug 9, 2022

Thank you @xabbuh.

@fabpot fabpot merged commit 1435a15 into symfony:5.4 Aug 9, 2022
@xabbuh xabbuh deleted the issue-46638 branch August 9, 2022 09:56
This was referenced Aug 26, 2022
Merged
Merged
Merged
@fabpot fabpot mentioned this pull request Sep 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogizanagi ogizanagi ogizanagi approved these changes

@fabpot fabpot fabpot approved these changes

@welcoMattic welcoMattic welcoMattic approved these changes

Assignees
No one assigned
Labels
Bug Status: Reviewed Validator
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
5 participants
@xabbuh @fabpot @welcoMattic @ogizanagi @carsonbot
0