Update PULL_REQUEST_TEMPLATE.md #47165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
approved these changes
Aug 2, 2022
OskarStark
approved these changes
Aug 2, 2022
There was a problem hiding this comment.
It's short enough to have a chance to get merged by @fabpot 😄
I think it could be helpful, let's give it a try
fabpot
reviewed
Aug 3, 2022
fabpot
approved these changes
Aug 3, 2022
|
Thank you @94noni. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose to add this info to encourage devs to auto describe their new feature added in their PR description to ease the addition in the documentation later
When browsing the auto PR on the symfony-docs repo, pointing to a recent merged PR, it may and probably should allow easier/better documentation integration process after feature is merged :)
friendly ping @javiereguiluz @wouterj @OskarStark
——
It reminds me https://blog.codinghorror.com/if-it-isnt-documented-it-doesnt-exist