10000 Fix Command::run phpdoc by VincentLanglet · Pull Request #46857 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Fix Command::run phpdoc #46857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 5, 2022
Merged

Fix Command::run phpdoc #46857

merged 1 commit into from
Jul 5, 2022

Conversation

VincentLanglet
Copy link
Contributor
Q A
Branch? 4.4
Bug fix? Phpdoc-fix
New feature? no
Deprecations? no
Tickets Fix #...
License MIT
Doc PR symfony/symfony-docs#...

Command::run is doing

try {
            $input->bind($this->definition);
        } catch (ExceptionInterface $e) {
            if (!$this->ignoreValidationErrors) {
                throw $e;
            }
        }

Since, bind only throws ExceptionInterface and we re-throw this exception, the only exception thrown by the run method are ExceptionInterface and not \Exception which is too generic and out of Symfony namespace.

@VincentLanglet VincentLanglet requested a review from chalasr as a code owner July 5, 2022 11:55
@carsonbot carsonbot added this to the 4.4 milestone Jul 5, 2022
chalasr
chalasr reviewed Jul 5, 2022
View reviewed changes
@fabpot
Copy link
Member
fabpot commented Jul 5, 2022

Thank you @VincentLanglet.

@fabpot fabpot force-pushed the fixCommandPhpdoc branch from a3f94f9 to bedd5ae Compare July 5, 2022 17:42
@fabpot fabpot merged commit 04ae33a into symfony:4.4 Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@VincentLanglet @fabpot @chalasr @carsonbot
0