8000 [FrameworkBundle] Disable Serializer data collect by default by chalasr · Pull Request #46625 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[FrameworkBundle] Disable Serializer data collect by default #46625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agr 8000 ee to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2022

Conversation

chalasr
Copy link
Member
@chalasr chalasr commented Jun 9, 2022
Q A
Branch? 6.1
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix symfony/maker-bundle#1252
License MIT
Doc PR TODO

The serializer data collector introduced in 6.1. causes a BC break for some (see fixed ticket).
This PR adds a framework.profiler.collect_serializer_data option defaulting to false, allowing people to fix their code before activating it.

Next steps:

  • deprecate the ObjectNormalizer autowiring alias on 6.2 and fix the docs accordingly
  • deprecate the option

Build failures unrelated.

@nicolas-grekas
Copy link
Member
nicolas-grekas commented Jun 9, 2022

Do we want to enable this by default for new projects via a recipe? Can you please send a PR doing so if yes?

@nicolas-grekas
Copy link
Member

Thank you @chalasr.

@nicolas-grekas nicolas-grekas merged commit 3184226 into symfony:6.1 Jun 9, 2022
@chalasr chalasr deleted the serializer-collect-optin branch June 9, 2022 13:05
@chalasr
Copy link
Member Author
chalasr commented Jun 9, 2022

Here is the recipe PR symfony/recipes#1095

@fabpot fabpot mentioned this pull request Jun 9, 2022
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this pull request Aug 11, 2022
…r.collect_serializer_data` option (chalasr)

This PR was merged into the 6.1 branch.

Discussion
----------

[FrameworkBundle] Document the `framework.profiler.collect_serializer_data` option

Documents the option added in symfony/symfony#46625.

Commits
-------

e33e717 [FrameworkBundle] Document the `framework.profiler.collect_serializer_data` option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0