8000 [Cache][Lock][VarExporter] Remove dead branches of PHP version checks by derrabus · Pull Request #46513 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Cache][Lock][VarExporter] Remove dead branches of PHP version checks #46513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 31, 2022
Merged

[Cache][Lock][VarExporter] Remove dead branches of PHP version checks #46513

merged 1 commit into from
May 31, 2022

Conversation

@derrabus
Copy link
Member
@derrabus derrabus commented May 30, 2022
Q A
Branch? 6.2
Bug fix? no
New feature? no
Deprecations? no
Tickets N/A
License MIT
Doc PR N/A

This PR removes various code that won't be executed on PHP 8.1 and above.

@derrabus derrabus requested a review from jderusse as a code owner May 30, 2022 22:16
@carsonbot carsonbot added this to the 6.2 milestone May 30, 2022
@carsonbot carsonbot changed the title Remove dead branches of PHP version checks [Cache][Lock][VarExporter] Remove dead branches of PHP version checks May 30, 2022
@nicolas-grekas
Copy link
Member
nicolas-grekas commented May 31, 2022

Thank you @derrabus.

@nicolas-grekas nicolas-grekas merged commit 2424b43 into symfony:6.2 May 31, 2022
@derrabus derrabus deleted the improvement/php-version-tautologies branch May 31, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stof stof stof approved these changes

@jderusse jderusse Awaiting requested review from jderusse jderusse is a code owner

Assignees

No one assigned

Labels

Cache Lock Status: Reviewed VarExporter

Projects

None yet

Milestone

6.2

Development

Successfully merging this pull request may close these issues.

4 participants

@derrabus @nicolas-grekas @stof @carsonbot
0