[FrameworkBundle] Fix dumping extension config without bundle #46412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9982f1c to
42fa0cb
Compare
chalasr
approved these changes
May 20, 2022
nicolas-grekas
approved these changes
May 21, 2022
|
Thank you @yceruto. |
xabbuh
reviewed
May 21, 2022
| @@ -59,7 +60,7 @@ protected function listBundles($output) | |||
| /** | |||
| * @return ExtensionInterface | |||
| */ | |||
| protected function findExtension($name) | |||
| protected function findExtension($name, ContainerBuilder $container) | |||
There was a problem hiding this comment.
My bad!
I don't remember, is it ok to add a new deprecation in a patch version?
There was a problem hiding this comment.
We cannot do that in a patch release.
fabpot
added a commit
that referenced
this pull request
May 22, 2022
… (yceruto) This PR was merged into the 4.4 branch. Discussion ---------- [FrameworkBundle] Fix BC break in abstract config commands | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Fixes #46412 This revert also the unnecessary changes made in ConfigDebugCommand and ConfigDumpReferenceCommand classes Commits ------- 5be61fa Fix BC break
This was referenced May 27, 2022
Merged
Merged
Merged
Merged
Sign up for free
to j
752F
oin this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Either the
debug:configorconfig:dump-referencecommands allow to pass the bundle name or the extension alias as first argument. However, when we register an extension without a bundle (i.e. it's directly registered in the kernel class or the kernel class implementsExtensionInterface), these commands cannot dump the configuration related to this extension.This PR fixes the issue, so both commands will look at the extensions list regardless of whether it belongs to a bundle.