Adding the database to the DSN we are sending to the MongoDB server #4640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -114,7 +114,7 @@ protected function getMongo() | |||
| { | |||
| if ($this->mongo === null) { | |||
| if (preg_match('#^(mongodb://.*)/(.*)/(.*)$#', $this->dsn, $matches)) { | |||
| $mongo = new \Mongo($matches[1]); | |||
| $mongo = new \Mongo($matches[1] . '/' . $matches[2]); | |||
There was a problem hiding this comment.
You should check if it's not empty before using it, as an empty value will fail now.
There was a problem hiding this comment.
Thanks for the valid comment, fixed in 45d0748 :)
|
It looks to me like travisbot failed because of an error in the routing system that was fixed in c67cf8b, not because of the code I altered. |
| @@ -114,7 +114,7 @@ protected function getMongo() | |||
| { | |||
| if ($this->mongo === null) { | |||
| if (preg_match('#^(mongodb://.*)/(.*)/(.*)$#', $this->dsn, $matches)) { | |||
| $mongo = new \Mongo($matches[1]); | |||
| $mongo = new \Mongo($matches[1] . ($matches[2] != null && !empty($matches[2]) ? '/' . $matches[2] : '')); | |||
|
Can you squash your commits before I merge? Thanks. |
|
I think I've managed to do that, but correct me if I've done something wrong :) |
|
@Wotre Unfortunately, that's wrong. You can read how to do that in the contrib docs: http://symfony.com/doc/current/contributing/code/patches.html#rework-your-patch |
|
Thanks for the help, looks like I forgot the -f when pushing. It should be okay now |
fabpot
added a commit
that referenced
this pull request
Jun 26, 2012
Commits ------- 81d0552 Adding the database to the DSN we are sending to the MongoDB server Discussion ---------- Adding the database to the DSN we are sending to the MongoDB server Adding the database to the DSN we are sending to the MongoDB server. According to the [documentation from PHP](http://be2.php.net/manual/en/mongo.construct.php) the database will default to admin if it isn't specified in this DSN. Unfortunately the username we're trying to login with shouldn't have access to this database. --------------------------------------------------------------------------- by travisbot at 2012-06-23T13:54:28Z This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1688817) (merged 2251be90 into 0d4b02e). --------------------------------------------------------------------------- by travisbot at 2012-06-25T11:34:17Z This pull request [fails](http://travis-ci.org/symfony/symfony/builds/1700214) (merged 45d0748b into 0d4b02e). --------------------------------------------------------------------------- by Wotre at 2012-06-25T12:16:49Z It looks to me like travisbot failed because of an error in the routing system that was fixed in c67cf8b, not because of the code I altered. --------------------------------------------------------------------------- by travisbot at 2012-06-25T16:45:12Z This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1702410) (merged aa659463 into 0d4b02e). --------------------------------------------------------------------------- by fabpot at 2012-06-26T05:07:37Z Can you squash your commits before I merge? Thanks. --------------------------------------------------------------------------- by Wotre at 2012-06-26T12:02:02Z I think I've managed to do that, but correct me if I've done something wrong :) --------------------------------------------------------------------------- by travisbot at 2012-06-26T12:05:19Z This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1710220) (merged dcb79089 into 0d4b02e). --------------------------------------------------------------------------- by fabpot at 2012-06-26T12:14:28Z @Wotre Unfortunately, that's wrong. You can read how to do that in the contrib docs: http://symfony.com/doc/current/contributing/code/patches.html#rework-your-patch --------------------------------------------------------------------------- by Wotre at 2012-06-26T12:37:59Z Thanks for the help, looks like I forgot the -f when pushing. It should be okay now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the database to the DSN we are sending to the MongoDB server.
According to the documentation from PHP the database will default to admin if it isn't specified in this DSN. Unfortunately the username we're trying to login with shouldn't have access to this database.