[Form] Fixed the validation of form validation constraints #4625
Conversation
Validating the form constraints for each validation group results in duplicated errors when several validation groups are used.
|
I don't think that walking the constraints in Default group instead should be the solution. Instead, we should check whether the constraints are member of the validated groups before actually validating them. We could also presort the constraints, like it is done in the GraphWalker. |
|
@bschussek The constraint added on the Fomr are not member of any group. Previously, it was considering that they are part of all groups, and I changed it so that they are validated only for one group. |
|
@s 8000 tof They usually are members of group Default, but one could easily add constraints with different groups. |
|
@bschussek you cannot specify groups for the constraint added in a form. and currently, the code was considering they were in all groups used by the form, thus validating them several times. |
|
@stof Why couldn't you set groups for them? |
|
@bschussek this would not change anything. Look at the way the FormValidator is using these constraints. |
|
I know. That's the problem I am talking about :)
|
|
Closing in favor of #4810 |
Validating the form constraints for each validation group results in
duplicated errors when several validation groups are used.
This is an attempt to fix #4427.
@bschussek can you look at it ? I'm not sure if it is the right way to fix it.
Looking at the code of the GraphWalker to debug this, I think we have an issue in the validator component itself (and the Form constraints being only the easiest way to trigger the issue): if a constraint is attached on an object in 2 validation groups and you use both groups when calling the validator, the ConstraintValidator is called twice. This is not something you will generally do in your constraint mapping, but the FormValidator was working in such a way: form constraints were validated for all validation groups of the form. However, I don't see how the GraphWalker could remember the constraint has already been validated for this instance as walkConstraint does not have access to the object.