[HttpClient][Translation][Workflow] [Service] Exclude tests from classmaps #46134
Conversation
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
|
It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you. Cheers! Carsonbot |
|
Thank you @danog. |
…sts from classmaps (danog) This PR was squashed before being merged into the 6.1 branch. Discussion ---------- [HttpClient][Translation][Workflow] [Service] Exclude tests from classmaps | Q | A | ------------- | --- | Branch? | 6.1 | Bug fix? | yes | New feature? | no | Deprecations? | no This excludes test directories from production classmaps. Commits ------- c5880a2 [HttpClient][Translation][Workflow] [Service] Exclude tests from classmaps
|
I think this is a breaking change for projects that use this classes and install dependencies with authoritative class maps, which is a good practice for performances. |
|
Tests + authoritative class maps looks like a mismatch to me. I don't think this will affect anyone. Let's see if anyone reports it later on :) |
This excludes test directories from production classmaps.