[FrameworkBundle] Add support for first-class callable route controller in MicroKernelTrait #46009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er in MicroKernelTrait
fancyweb
commented
Apr 12, 2022
| @@ -214,6 +214,8 @@ public function loadRoutes(LoaderInterface $loader): RouteCollection | |||
|
|
|||
| if (\is_array($controller) && [0, 1] === array_keys($controller) && $this === $controller[0]) { | |||
| $route->setDefault('_controller', ['kernel', $controller[1]]); | |||
| } elseif ($controller instanceof \Closure && $this === ($r = new \ReflectionFunction($controller))->getClosureThis() && !str_contains($r->name, '{closure}')) { | |||
There was a problem hiding this comment.
Anonymous functions and outside closures will continue to fail.
8000
fancyweb
commented
Apr 12, 2022
nicolas-grekas
approved these changes
Apr 12, 2022
|
Thank you @fancyweb. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have some routes defined in
Kernel.phpwith the following syntax:I'd like to switch them to:
Because I'd like to use first-class callable syntax everywhere in the project.