8000 [SecurityHttp] Implementing Null Object Design Pattern in AuthenticatorManager by Trismegiste · Pull Request #45953 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[SecurityHttp] Implementing Null Object Design Pattern in AuthenticatorManager #45953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[SecurityHttp] Implementing Null Object Design Pattern in AuthenticatorManager #45953

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a55868
Implementing Null Object Design Pattern for $logger and removing 15 (…
Trismegiste Apr 6, 2022
1c5b4d8
Fixing coding standard
Trismegiste Apr 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fixing coding standard
  • Loading branch information
@Trismegiste
Trismegiste committed Apr 6, 2022
commit 1c5b4d849f8f016d196484af61cb1e20b7e2472c
2 changes: 1 addition & 1 deletion src/Symfony/Component/Security/Http/Authentication/AuthenticatorManager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ public function __construct(iterable $authenticators, TokenStorageInterface $tok
$this->tokenStorage = $tokenStorage;
$this->eventDispatcher = $eventDispatcher;
$this->firewallName = $firewallName;
$this->logger = is_null($logger) ? new NullLogger() : $logger;
$this->logger = null === $logger ? new NullLogger() : $logger;
$this->eraseCredentials = $eraseCredentials;
$this->hideUserNotFoundExceptions = $hideUserNotFoundExceptions;
$this->requiredBadges = $requiredBadges;
Expand Down
0