[Console] Use 'mode' command to detect terminal size on Windows #4594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (defined('PHP_WINDOWS_VERSION_BUILD')) { | ||
| exec('mode CON', $execData); | ||
|
|
||
| if(preg_match('{columns:\s*(\d+)}i', $execData[4], $matches)) { |
|
ping @Seldaek |
|
It's a good addition, but you should still use ANSICON first if it's available. mode returns the buffer size and not the window size, which means the lines are not the real terminal height, but the buffer setting. ANSICON has both informations and hence allows you to be more correct. For columns/width both offer equally good information since the buffer size is not bigger than the window. |
|
Can you squash your commits before I merge? Thanks. |
|
Yes that's fine. |
|
@jcowgill there are still 3 commits. |
|
Woops, it's done now |
fabpot
added a commit
that referenced
this pull request
Jun 18, 2012
Commits ------- bb87a71 [Console] Use 'mode' command to detect terminal size on Windows Discussion ---------- [Console] Use 'mode' command to detect terminal size on Windows This PR uses the windows 'mode' command to get the terminal height and width on windows. I've left in the ANSICON stuff but I'm not sure if that's needed after this. --------------------------------------------------------------------------- by travisbot at 2012-06-16T10:37:25Z This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1634120) (merged a490b6ec into f881d28). --------------------------------------------------------------------------- by fabpot at 2012-06-16T16:17:24Z ping @Seldaek --------------------------------------------------------------------------- by Seldaek at 2012-06-16T17:03:22Z It's a good addition, but you should still use ANSICON first if it's available. mode returns the buffer size and not the window size, which means the lines are not the real terminal height, but the buffer setting. ANSICON has both informations and hence allows you to be more correct. For columns/width both offer equally good information since the buffer size is not bigger than the window. --------------------------------------------------------------------------- by fabpot at 2012-06-17T10:41:21Z Can you squash your commits before I merge? Thanks. --------------------------------------------------------------------------- by jcowgill at 2012-06-17T13:23:01Z Yes that's fine. --------------------------------------------------------------------------- by fabpot at 2012-06-18T12:04:43Z @jcowgill there are still 3 commits. --------------------------------------------------------------------------- by jcowgill at 2012-06-18T14:59:51Z Woops, it's done now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the windows 'mode' command to get the terminal height and width on windows.
I've left in the ANSICON stuff but I'm not sure if that's needed after this.