8000 [DependencyInjection] Add argument type `closure` to help passing closures to services by nicolas-grekas · Pull Request #45878 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[DependencyInjection] Add argument type closure to help passing closures to services #45878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2022
Merged

[DependencyInjection] Add argument type closure to help passing closures to services #45878

merged 1 commit into from
Mar 30, 2022

Conversation

nicolas-grekas
Copy link
Member
Q A
Branch? 6.1
Bug fix? no
New feature? yes
Deprecations? no
Tickets -
License MIT
Doc PR -

Inspired by #45873

This makes it easier to inject invokable services as closures.

Before:

services:
  # [...]
    arguments:
      - !service
          class: Closure
          factory: [Closure, fromCallable]
          arguments: ['@my.invokable']

After:

services:
  # [...]
    arguments:
      - !closure '@my.invokable'

As a bonus, PhpDumper now optimizes Closure::fromCallable into first-class callable syntax.

@carsonbot carsonbot added this to the 6.1 milestone Mar 29, 2022
@fabpot
Copy link
Member

fabpot commented Mar 30, 2022

Thank you @nicolas-grekas.

@fabpot fabpot mentioned this pull request Mar 30, 2022
Closed
@fabpot fabpot merged commit 7cdf8b4 into symfony:6.1 Mar 30, 2022
@nicolas-grekas nicolas-grekas deleted the di-closure branch March 30, 2022 14:19
@fabpot fabpot mentioned this pull request Apr 15, 2022
Merged
@nicolas-grekas nicolas-grekas mentioned this pull request Mar 8, 2023
Merged
@Kocal Kocal mentioned this pull request Apr 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof left review comments

@GromNaN GromNaN GromNaN approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
DependencyInjection Feature Status: Reviewed
Projects
None yet
Milestone
6.1
Development

Successfully merging this pull request may close these issues.
6 participants
@nicolas-grekas @fabpot @GromNaN @stof @chalasr @carsonbot
0