8000 [HttpKernel]  Resolve DateTime values with default timezone by GromNaN · Pull Request #45874 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[HttpKernel]  Resolve DateTime values with default timezone #45874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 29, 2022
Merged

[HttpKernel]  Resolve DateTime values with default timezone #45874

merged 1 commit into from
Mar 29, 2022

Conversation

GromNaN
Copy link
Member
@GromNaN GromNaN commented Mar 28, 2022 •
edited
Loading
Q A
Branch? 6.1
Bug fix? yes
New feature? no
Deprecations? no
Tickets #45865 (comment)
License MIT
Doc PR -

Alternative to #45865 by Nicolas Grekas.

Make sure the date input is parsed using the default timezone and the resulting DateTimeInterface instance has the default timezone. Except for timestamps, which are UTC by standard.

@GromNaN GromNaN added this to the 6.1 milestone Mar 28, 2022
@GromNaN GromNaN requested a review from nicolas-grekas March 28, 2022 20:03
@carsonbot carsonbot changed the title [HttpKernel] Resolve DateTime values with default timezone [HttpKernel]  Resolve DateTime values with default timezone Mar 28, 2022
@GromNaN GromNaN mentioned this pull request Mar 28, 2022
Closed
nicolas-grekas
nicolas-grekas approved these changes Mar 28, 2022
View reviewed changes
Copy link
Member
@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(but fabbot ;))

@fabpot
Copy link
Member
fabpot commented Mar 29, 2022

Thank you @GromNaN.

@fabpot fabpot merged commit 1db1443 into symfony:6.1 Mar 29, 2022
@GromNaN GromNaN deleted the resolve-date-tz branch March 29, 2022 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Bug HttpKernel Status: Reviewed
Projects
None yet
Milestone
6.1
Development

Successfully merging this pull request may close these issues.
4 participants
@GromNaN @fabpot @nicolas-grekas @carsonbot
0