[TwigBundle] Pre-compile only *.twig files in cache warmup #45845
Conversation
|
I'm not sure about this change, but this can only be merged in 6.1 anyway as this is a behavior change and not a bug fix (we always consider performance improvements as a new feature). |
|
Ok for 6.1. The question to answer before merging this PR is: is it expected to have twig templates that does not have the The alternative in my code is to decorate the iterator and filter each template name. class TemplateIterator implements \IteratorAggregate
{
public function __construct(private iterable $iterator) {}
public function getIterator(): \Generator
{
foreach ($this->iterator as $filename) {
if (str_ends_with($filename, '.twig')) {
yield $filename;
}
}
}
}And use a compiler pass to inject the decorator in the cache warmer. class TemplateIteratorPass implements CompilerPassInterface
{
public function process(ContainerBuilder $container)
{
$warmer = $container->getDefinition('twig.template_cache_warmer');
$iterator = $container->register(TemplateIterator::class, TemplateIterator::class)->addArgument($warmer->getArgument(1));
$warmer->setArgument(1, $iterator);
}
} |
I think that this is indeed a great question. And the answer is: you can have templates with another extension. It's probably not widespread but nothing forbids it. |
|
I added an option to the twig:
file_name_pattern: "*.twig"
|
|
Unfortunately, the deprecation is not reported in logs when running |
src/Symfony/Bundle/TwigBundle/DependencyInjection/Configuration.php
Outdated
Show resolved
Hide resolved
In Symfony WebProfilerBundle itself, all svg are included as templates with Zurb templates uses the See #45858 |
|
Thanks @yceruto. This proves this issue is common. Your PR was almost the same, with excluded directories in addition. @fabpot presented the argument that |
|
Thank you @GromNaN. |
…colas-grekas) This PR was merged into the 6.1 branch. Discussion ---------- [TwigBridge] Make LintCommand::$namePatterns private | Q | A | ------------- | --- | Branch? | 6.1 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Dunno why this wasn't done in #45845. /cc `@GromNaN` any idea? Commits ------- 627a296 [TwigBridge] Make LintCommand::$namePatterns private
In my project, the template directory contains all the frontend assets (CSS, JS and images), this is a choice to locate all component files in the same directories. But the asset files are compiled as if they were twig template, which is a waste of time and storage.
This patch limit warmup to*.twigfiles.This PR adds an option to restrict file pattern, for cache warmup and lint.
The filter on
*.twigfiles is already in thelint:twigcommand.Note: If a non-twig template is included in a template (ex: to inline CSS), the
source()function must be used ; the cache is not used in this case.Edit: Here is the documentation https://symfony.com/doc/current/reference/configuration/twig.html#file-name-pattern