8000 [Serializer] Fix denormalizing union types by T-bond · Pull Request #45838 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Serializer] Fix denormalizing union types #45838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2022
Merged

[Serializer] Fix denormalizing union types #45838

merged 1 commit into from
Mar 24, 2022

Conversation

@T-bond
Copy link
Contributor
@T-bond T-bond commented Mar 24, 2022
Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #45818
License MIT
Doc PR -

@nicolas-grekas Replaces: #45824 as I accidentally registerred a lot of people to the notifier list when changing target branch.

Note about difference between docblock vs PHP 8 union types:
With PHP 8 union types, the resolved $types array was always (when I checked) in the same order, no matter the type definition.
So these two things: public null|boolean|DateTime and public DateTime|boolean|null would always generate an array, where the first item was DateTime.

With PHP docblock the $tpyes array order depends of the order of the documentation.
So the * @var \DateTime|bool|null would resolve to an array with DateTime as first item, but the * @var null|bool|\DateTime would resolve to the DateTime being the last element.

8000

@T-bond T-bond requested a review from dunglas as a code owner March 24, 2022 15:06
@carsonbot carsonbot added this to the 4.4 milestone Mar 24, 2022
T-bond
T-bond commented Mar 24, 2022
View reviewed changes
Copy link
Contributor Author
@T-bond T-bond left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self review done. All checks have passed.

Again, thanks for this great software! :)

Status: Reviewed

@nicolas-grekas nicolas-grekas changed the title [Serializer] Allow denormalizing union types properly [Serializer] Fix denormalizing union types Mar 24, 2022
@nicolas-grekas
Copy link
Member

Thank you @T-bond.

@nicolas-grekas nicolas-grekas merged commit 62344fd into symfony:4.4 Mar 24, 2022
@T-bond T-bond mentioned this pull request Mar 27, 2022
Closed
This was referenced Apr 2, 2022
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

Assignees

No one assigned

Labels

Bug Serializer Status: Needs Review

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

3 participants

@T-bond @nicolas-grekas @carsonbot
0