[DependencyInjection] add AsDecorator class attribute and InnerService parameter attribute #45834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. I see several issues with the current approach:
Instead of adding a new pass, I think the attributes should be looked for in AutowirePass, where there is already some logic that deals with decoration. This would fix all listed issues I believe. |
src/Symfony/Component/DependencyInjection/Compiler/AutowirePass.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/DependencyInjection/Compiler/RegisterDecoratorAttributesPass.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/DependencyInjection/Compiler/RegisterDecoratorAttributesPass.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/DependencyInjection/Compiler/RegisterDecoratorAttributesPass.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/DependencyInjection/Compiler/RegisterDecoratorAttributesPass.php
Outdated
Show resolved
Hide resolved
|
(please mind the PR title+description also ;)) |
|
Thanks for your reviews ! Code and description have been updated :) |
nicolas-grekas
approved these changes
Apr 14, 2022
|
I tried from a new demo application with : final class Foo implements FooInterface
{
public function __invoke(): string
{
return 'new '.__CLASS__.'()';
}
}
#[AsDecorator(decorates: Foo::class, decorationPriority: 10)]
final class Bar10 implements FooInterface
{
private FooInterface $foo;
public function __construct(#[InnerService] FooInterface $foo)
{
$this->foo = $foo;
}
public function __invoke(): string
{
return 'new '.__CLASS__.'('.($this->foo)().')';
}
}
#[AsDecorator(decorates: Foo::class, decorationPriority: 20)]
final class Bar20 implements FooInterface
{
private FooInterface $foo;
public function __construct(#[InnerServicce] FooInterface $foo)
{
$this->foo = $foo;
}
public function __invoke(): string
{
return 'new '.__CLASS__.'('.($this->foo)().')';
}
}
#[AsController]
class TestController
{
private FooInterface $foo;
public function __construct(#[Autowire(service: Foo::class)] FooInterface $foo)
{
$this->foo = $foo;
}
#[Route('/test/')]
public function index(): Response
{
return new Response(($this->foo)());
}
}Calling |
There was a problem hiding this comment.
<
8000
p dir="auto">Thanks! I'm just bike-shedding on the naming, WDYT?
Esp Inner vs DecoratedService? (or just Decorated)?
Any opinion @symfony/mergers? (see #45834 (comment) for examples)
Esp Inner vs DecoratedService? (or just Decorated)?
Any opinion @symfony/mergers? (see #45834 (comment) for examples)
src/Symfony/Component/DependencyInjection/Attribute/AsDecorator.php
Outdated
Show resolved
Hide resolved
…e parameter attribute
c0c5468 to
d8a4680
Compare
|
Thank you @Jean-Beru. |
fabpot
added a commit
that referenced
this pull request
Apr 22, 2022
…apDecorated]` (chalasr) This PR was merged into the 6.1 branch. Discussion ---------- [DependencyInjection] Rename `#[InnerService]` to `#[MapDecorated]` | Q | A | ------------- | --- | Branch? | 6.1 | Bug fix? | no | New feature? | no but tweaks one #45834 | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - When talking about the decorator pattern outside of Symfony, the term `inner` is pretty much (if not totally) inexistent. Worse, it makes the concept harder to explain. Take "there is a decorator and a decorated object" vs "there is a decorator and an inner object": using the later form, one has to explain both what is the decorator and what is the inner. While using the former, explaining what the decorator makes it obvious what the decorated is. I propose to take the addition of this attribute as an opportunity to start making this special term go away. Also I removed the `Service` suffix. It is tempting to keep it for explicitness, but it feels kinda redundant and AFAIK no other core attribute has such redundant suffix, maybe because their namespace is enough to indicate their target. Commits ------- c0a7979 [DependencyInjection] Rename `#[InnerService]` to `#[MapDecorated]`
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aim f this PR is to allow decorator declaration with PHP8 attributes by using
AsDecoratorattribute on class and, optionally,InnerServiceparameter attribute to inject decorated service.To use it :