8000 [DependencyInjection] fix `ServiceSubscriberTrait` bug where parent has `__call()` by kbond · Pull Request #45677 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[DependencyInjection] fix ServiceSubscriberTrait bug where parent has __call() #45677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 9, 2022
Merged

[DependencyInjection] fix ServiceSubscriberTrait bug where parent has __call() #45677

merged 1 commit into from
Mar 9, 2022

Conversation

kbond
Copy link
Member
@kbond kbond commented Mar 8, 2022 •
edited
Loading
Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets n/a
License MIT
Doc PR n/a

is_callable(['parent', __FUNCTION__]) is true if the parent has magic __call()/__callStatic methods. Discovered this when trying to use ServiceSubscriberTrait with a Doctrine ServiceEntityRepository.

@carsonbot carsonbot added this to the 4.4 milestone Mar 8, 2022
@kbond kbond force-pushed the bug/service-locator-magic-parent branch 2 times, most recently from e586e37 to b79dfce Compare March 8, 2022 18:26
nicolas-grekas
nicolas-grekas reviewed Mar 9, 2022
View reviewed changes
@kbond kbond force-pushed the bug/service-locator-magic-parent branch from b79dfce to 4b8cd52 Compare March 9, 2022 13:39
fabpot
fabpot approved these changes Mar 9, 2022
8000 View reviewed changes
@fabpot
Copy link
Member
fabpot commented Mar 9, 2022

Thank you @kbond.

@fabpot fabpot merged commit ab136f0 into symfony:4.4 Mar 9, 2022
@kbond kbond deleted the bug/service-locator-magic-parent branch March 9, 2022 18:28
This was referenced Apr 2, 2022
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@fabpot fabpot fabpot approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Bug DependencyInjection Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@kbond @fabpot @nicolas-grekas @chalasr @carsonbot
0