Fix Mailgun header format for Reply-To #45630
Conversation
In this moment is sent in lower case so: h:reply-to You can see the article is h:Reply-To https://help.mailgun.com/hc/en-us/articles/4401814149147-Adding-A-Reply-To-Address
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
|
Headers are not case sensitive. Are you sure it makes a difference? |
|
Some mail clients are reply to our from address no-reply after upgrading to symfony mailer and when I check my old mail sent with mailgun-php the only thing different that I find is that, but I would have to review in more depth the behavior of mailgum-php and the handling of the reply-to header Before: |
|
Closing in favor of #45816 |
This PR was merged into the 4.4 branch. Discussion ---------- [Mailer] Preserve case of headers | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | #45630 | License | MIT | Doc PR | - Commits ------- a64c6e6 [Mailer] Preserve case of headers
In this moment is sent in lower case so: h:reply-to
You can see the article is h:Reply-To
https://help.mailgun.com/hc/en-us/articles/4401814149147-Adding-A-Reply-To-Address