8000 [Intl] fix wrong offset timezone PHP 8.1 by Lenny4 · Pull Request #45460 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Intl] fix wrong offset timezone PHP 8.1 #45460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 18, 2022
Merged

[Intl] fix wrong offset timezone PHP 8.1 #45460

merged 1 commit into from
Feb 18, 2022

Conversation

Lenny4
Copy link
Contributor
@Lenny4 Lenny4 commented Feb 17, 2022 •
edited by nicolas-grekas
Loading
Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #45451
License MIT
Doc PR -

@carsonbot carsonbot added this to the 6.0 milestone Feb 17, 2022
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot carsonbot changed the title fix: fix wrong offset timezone PHP 8.1 [Intl] fix: fix wrong offset timezone PHP 8.1 Feb 17, 2022
@nicolas-grekas nicolas-grekas changed the title [Intl] fix: fix wrong offset timezone PHP 8.1 [Intl] fix wrong offset timezone PHP 8.1 Feb 17, 2022
@nicolas-grekas nicolas-grekas modified the milestones: 6.0, 4.4 Feb 17, 2022
@nicolas-grekas nicolas-grekas changed the base branch from 6.0 to 4.4 February 17, 2022 14:04
nicolas-grekas
nicolas-grekas reviewed Feb 17, 2022
View reviewed changes
Copy link
Member
@nicolas-grekas nicolas-grekas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed some changes, but I cannot reproduce the failure on my local setup.
When I revert the change, the new test case still passes. Can you confirm that's not the case for you?

@Lenny4
Copy link
Contributor Author
Lenny4 commented Feb 17, 2022 •
edited
Loading

@nicolas-grekas
Which PHP version were you using ?

@nicolas-grekas
Copy link
Member

With both PHP 8.1 and 7.4

@nicolas-grekas
Copy link
Member

I ran the test case with
./phpunit src/Symfony/Component/Intl/ --group intl-data --filter testGetRawOffsetChangeTimeCountry

@Lenny4
Copy link
Contributor Author
Lenny4 commented Feb 17, 2022

This is really strange I got the same result as you.

@ro0NL
Copy link
Contributor
ro0NL commented Feb 17, 2022

for me the patch works

docker run -it -v "$(pwd):/app" -w /app php:8.1 ./phpunit src/Symfony/Component/Intl/ --group intl-data --filter testGetRawOffsetChangeTimeCountry

@nicolas-grekas
Copy link
Member
nicolas-grekas commented Feb 17, 2022 •
edited
Loading

@ro0NL the issue is not that tests are red, it's that they are always green, even when using PHP 8.1 BEFORE THE PATCH.

ro0NL
ro0NL approved these changes Feb 17, 2022
View reviewed changes
Copy link
Contributor
@ro0NL ro0NL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PHP 8.1 docker images uses: "Olson" Timezone Database Version => 2021.5

and the test is red without this patch 👍

@nicolas-grekas
Copy link
Member

Thank you @Lenny4.

@nicolas-grekas nicolas-grekas merged commit 25ec51d into symfony:4.4 Feb 18, 2022
@fabpot fabpot mentioned this pull request Feb 28, 2022
Merged
This was referenced Feb 28, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@ro0NL ro0NL ro0NL approved these changes

@lyrixx lyrixx Awaiting requested review from lyrixx

@yceruto yceruto Awaiting requested review from yceruto

@wouterj wouterj Awaiting requested review from wouterj

@chalasr chalasr Awaiting requested review from chalasr

@dunglas dunglas Awaiting requested review from dunglas

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Bug Intl Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@Lenny4 @carsonbot @nicolas-grekas @ro0NL
0