[OptionsResolver] Added options resolver tests #4545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -215,4 +215,92 @@ public function testReplaceClearsAndSets() | |||
| 'three' => '3', | |||
| ), $this->options->all()); | |||
| } | |||
|
|
|||
| public function testClearIsRemoveAllOptions() | |||
There was a problem hiding this comment.
typo: testClearRemoves...
|
Fixed test names and replaced loop with iterator_to_array |
|
Could you please also squash the commits into one and prefix the commit message with "[OptionsResolver]"? |
[OptionsResolver] Fixed test names and iterator test
|
Commits squashed |
|
Thanks! @fabpot 👍 |
fabpot
added a commit
that referenced
this pull request
Jun 10, 2012
Commits ------- 83ff200 [OptionsResolver] Added options resolver tests to improve coverage Discussion ---------- [OptionsResolver] Added options resolver tests Bug fix: no Feature addition: no Backwards compatibility break: no Symfony2 tests pass: yes [](http://travis-ci.org/l3l0/symfony) License of the code: MIT --------------------------------------------------------------------------- by travisbot at 2012-06-10T09:14:34Z This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1581756) (merged 320617b6 into 6266b72). --------------------------------------------------------------------------- by l3l0 at 2012-06-10T11:41:15Z Fixed test names and replaced loop with iterator_to_array --------------------------------------------------------------------------- by travisbot at 2012-06-10T11:44:49Z This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1582569) (merged 68588202 into 6266b72). --------------------------------------------------------------------------- by bschussek at 2012-06-10T12:38:47Z Could you please also squash the commits into one and prefix the commit message with "[OptionsResolver]"? --------------------------------------------------------------------------- by l3l0 at 2012-06-10T12:56:20Z Commits squashed --------------------------------------------------------------------------- by travisbot at 2012-06-10T13:01:35Z This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1583038) (merged 83ff200 into 6266b72). --------------------------------------------------------------------------- by bschussek at 2012-06-10T14:52:16Z Thanks! @fabpot 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix: no
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
License of the code: MIT