8000 [DependencyInjection] Fix type binding by sveneld · Pull Request #45424 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[DependencyInjection] Fix type binding #45424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 16, 2022
Merged

[DependencyInjection] Fix type binding #45424

merged 1 commit into from
Feb 16, 2022

Conversation

sveneld
Copy link
Contributor
@sveneld sveneld commented Feb 15, 2022 •
edited by nicolas-grekas
Loading
Q A
Branch? 4.4
Bug fix? yes
License MIT

If $type is a scalar compiler pass should not check it in function is_subclass_of($type, \UnitEnum::class), because is_subclass_of trying to autoload class with name array, string, etc.

Related to #44979

@carsonbot carsonbot added this to the 6.1 milestone Feb 15, 2022
@sveneld sveneld changed the base branch from 6.1 to 5.4 February 15, 2022 14:00
@sveneld
Copy link
Contributor Author
sveneld commented Feb 16, 2022

@nicolas-grekas take a look, please

@nicolas-grekas nicolas-grekas modified the milestones: 6.1, 4.4 Feb 16, 2022
@nicolas-grekas nicolas-grekas changed the base branch from 5.4 to 4.4 February 16, 2022 14:23
@nicolas-grekas
Copy link
Member

Thank you @sveneld.

@nicolas-grekas nicolas-grekas merged commit 8056126 into symfony:4.4 Feb 16, 2022
@sveneld sveneld deleted the fix_type_bindings branch February 16, 2022 14:31
This was referenced Feb 28, 2022
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyrixx lyrixx Awaiting requested review from lyrixx

@yceruto yceruto Awaiting requested review from yceruto

@wouterj wouterj Awaiting requested review from wouterj

@chalasr chalasr Awaiting requested review from chalasr

@dunglas dunglas Awaiting requested review from dunglas

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Bug DependencyInjection Status: Needs Review
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
3 pa 3676 rticipants
@sveneld @nicolas-grekas @carsonbot
0