8000 [Translation] Add icu message support for the lokalise provider by DanielBadura · Pull Request #45368 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Translation] Add icu message support for the lokalise provider #45368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: 5.4
Choose a base branch
from
Open

[Translation] Add icu message support for the lokalise provider #45368

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d8a15cf
Add icu message support for the lokalise provider
DanielBadura Feb 9, 2022
375cc98
fix the codestyle
DanielBadura Feb 9, 2022
7a6b771
remove icu detection instead user can configure it now for the provider
DanielBadura Mar 2, 2022
1607e56
update tests and add new ones
DanielBadura Mar 2, 2022
2603a21
cs fix
DanielBadura Mar 2, 2022
967df36
fix integration test cases caused by adjusting ProviderTestCase by ad…
DanielBadura Mar 2, 2022
692f87a
rename configuration to match it with the variablename in the impleme…
DanielBadura Mar 28, 2022
33041a6
provider are default with intl-icu disabled
DanielBadura Jun 15, 2022
4167b96
Fix test due to missing domain suffix
DanielBadura Jul 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
cs fix
  • Loading branch information
@DanielBadura
DanielBadura committed Jun 15, 2022
commit 2603a2132be907b9a63a40df9d21c46d30bf288a
4 changes: 2 additions & 2 deletions src/Symfony/Component/Translation/Bridge/Lokalise/Tests/LokaliseProviderTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -663,7 +663,7 @@ public function getResponsesForOneLocaleAndOneDomainWithIntlIcuEnabled(): \Gener
$expectedTranslatorBagEn->addCatalogue($arrayLoader->load([
'index.hello' => 'Hello',
'index.greetings' => 'Welcome, {firstname}!',
], 'en', 'messages' . MessageCatalogueInterface::INTL_DOMAIN_SUFFIX));
], 'en', 'messages'.MessageCatalogueInterface::INTL_DOMAIN_SUFFIX));

yield ['en', 'messages', <<<'XLIFF'
<?xml version="1.0" encoding="UTF-8"?>
Expand Down Expand Up @@ -693,7 +693,7 @@ public function getResponsesForOneLocaleAndOneDomainWithIntlIcuEnabled(): \Gener
$expectedTranslatorBagFr->addCatalogue($arrayLoader->load([
'index.hello' => 'Bonjour',
'index.greetings' => 'Bienvenue, {firstname} !',
], 'fr', 'messages' . MessageCatalogueInterface::INTL_DOMAIN_SUFFIX));
], 'fr', 'messages'.MessageCatalogueInterface::INTL_DOMAIN_SUFFIX));

yield ['fr', 'messages', <<<'XLIFF'
<?xml version="1.0" encoding="UTF-8"?>
Expand Down
0