8000 [PropertyAccessor] Add missing TypeError catch by b1rdex · Pull Request #45306 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[PropertyAccessor] Add missing TypeError catch #45306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 4, 2022
Merged

[PropertyAccessor] Add missing TypeError catch #45306

merged 1 commit into from
Feb 4, 2022

Conversation

b1rdex
Copy link
Contributor
@b1rdex b1rdex commented Feb 4, 2022
Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #45199
License MIT

This bugfix wraps TypeError: Cannot assign TYPE to property *::$* of type TYPE with InvalidArgumentException.

@carsonbot carsonbot added this to the 4.4 milestone Feb 4, 2022
@b1rdex b1rdex mentioned this pull request Feb 4, 2022
Closed
@b1rdex b1rdex force-pushed the property-accessor-type-error branch from 3c5dfb9 to db257f3 Compare February 4, 2022 12:48
@nicolas-grekas
Copy link
Member

Thank you @b1rdex.

@nicolas-grekas nicolas-grekas merged commit d3df7be into symfony:4.4 Feb 4, 2022
@b1rdex b1rdex deleted the property-accessor-type-error branch February 6, 2022 01:32
This was referenced Feb 28, 2022
Merged
Merged
Merged
xabbuh added a commit to xabbuh/rich-model-forms-bundle that referenced this pull request Apr 16, 2022
@xabbuh
account for exception handling changes in the core property accessor
1ca9f60 
see symfony/symfony#45306
@xabbuh xabbuh mentioned this pull request Apr 16, 2022
Merged
xabbuh added a commit to xabbuh/rich-model-forms-bundle that referenced this pull request Apr 16, 2022
@xabbuh
account for exception handling changes in the core property accessor
7c8ee45 
see symfony/symfony#45306
xabbuh added a commit to opensoftwareconsulting/rich-model-forms-bundle that referenced this pull request Apr 16, 2022
@xabbuh
minor #116 account for exception handling changes in the core propert…
7f49227 
…y accessor (xabbuh)

This PR was merged into the 0.2-dev branch.

Discussion
----------

account for exception handling changes in the core property accessor

see symfony/symfony#45306

Commits
-------

7c8ee45 account for exception handling changes in the core property accessor
@lyrixx lyrixx mentioned this pull request Apr 15, 2023
Merged
@HypeMC HypeMC mentioned this pull request Dec 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@fancyweb fancyweb fancyweb approved these changes

Assignees
No one assigned
Labels
Bug Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@b1rdex @nicolas-grekas @fancyweb @carsonbot
0