[Security] Take post_only into consideration in requiresAuthentication
#4525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@henrikbjorn could you squash the commit, or cherry-pick the third one so that it is the only one ? The reverted commit seems weird in the PR. |
|
@stof there. Actually it cannot be squashed. But maybe what i did was wrong. git reset --hard b84b46ba1a4e1197d1e8874c395bcf661d52191d
git cherry-pick af676bb5d01f835b2f9913e129e6c6eb3320dd26
git push -f henrikbjorn require-authentication |
|
@fabpot 👍 |
fabpot
added a commit
that referenced
this pull request
Jun 9, 2012
Commits ------- 6a01d3d [Security] Check post_only option and request method Discussion ---------- [Security] Take `post_only` into consideration in requiresAuthentication Change requiresAuthentication to look at the `post_only` option. Fixes #4524 --------------------------------------------------------------------------- by travisbot at 2012-06-08T18:26:21Z This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1570033) (merged 6d79949 into b84b46b). --------------------------------------------------------------- 7B09 ------------ by travisbot at 2012-06-09T11:34:59Z This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1575681) (merged af676bb5 into b84b46b). --------------------------------------------------------------------------- by stof at 2012-06-09T14:01:21Z @henrikbjorn could you squash the commit, or cherry-pick the third one so that it is the only one ? The reverted commit seems weird in the PR. --------------------------------------------------------------------------- by henrikbjorn at 2012-06-09T14:18:08Z @stof there. Actually it cannot be squashed. But maybe what i did was wrong. ``` shell git reset --hard b84b46b git cherry-pick af676bb5d01f835b2f9913e129e6c6eb3320dd26 git push -f henrikbjorn require-authentication ``` --------------------------------------------------------------------------- by travisbot at 2012-06-09T14:22:59Z This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1576658) (merged 6a01d3d into 3bb7dc0). --------------------------------------------------------------------------- by stof at 2012-06-09T14:39:25Z @fabpot 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change requiresAuthentication to look at the
post_onlyoption. Fixes #4524