8000 [Serializer] Set context annotation as not final by benjaminmal · Pull Request #45155 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Serializer] Set context annotation as not final #45155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 25, 2022
Merged

[Serializer] Set context annotation as not final #45155

merged 1 commit into from
Jan 25, 2022

Conversation

benjaminmal
Copy link
Q A
Branch? 6.1
Bug fix? no
New feature? yes
Deprecations? no
Tickets #45106
License MIT
Doc PR N/A

Allow extending Context annotation for creating custom annotations.

This is my first PR for Symfony, don't hesitate to tell if something is wrong with it ;)

@benjaminmal benjaminmal requested a review from dunglas as a code owner January 24, 2022 14:09
@carsonbot carsonbot added this to the 6.1 milestone Jan 24, 2022
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@fabpot
Copy link
Member
fabpot commented Jan 25, 2022

Thank you @benjaminmal.

@fabpot fabpot merged commit b342c1b into symfony:6.1 Jan 25, 2022
@fabpot fabpot mentioned this pull request Jan 25, 2022
Closed
@benjaminmal benjaminmal deleted the not-final-context-annotation branch January 25, 2022 16:31
@fabpot fabpot mentioned this pull request Apr 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@dunglas dunglas dunglas approved these changes

@derrabus derrabus derrabus approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Feature Serializer Status: Reviewed
Projects
None yet
Milestone
6.1
Development

Successfully merging this pull request may close these issues.
6 participants
@benjaminmal @carsonbot @fabpot @dunglas @derrabus @chalasr
0