[Validator] Improve Image constraint invalid mime type message #45090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
added a commit
that referenced
this pull request
Feb 24, 2022
…ints (fancyweb) This PR was merged into the 4.4 branch. Discussion ---------- [Validator] Improve tests for the Image and File constraints | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | - | Tickets | - | License | MIT | Doc PR | - For #45090 but submitting it on the lowest branch possible. Commits ------- 1a82c71 [Validator] Improve tests for the Image and File constraints
symfony-splitter
pushed a commit
to symfony/validator
that referenced
this pull request
Feb 24, 2022
…ints (fancyweb) This PR was merged into the 4.4 branch. Discussion ---------- [Validator] Improve tests for the Image and File constraints | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | - | Tickets | - | License | MIT | Doc PR | - For symfony/symfony#45090 but submitting it on the lowest branch possible. Commits ------- 1a82c716ba [Validator] Improve tests for the Image and File constraints
0e66dbe to
ef6be5e
Compare
fabpot
approved these changes
Mar 26, 2022
fabpot
requested changes
Mar 26, 2022
ef6be5e to
b82a145
Compare
|
Thank you @fancyweb. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using:
Uploading a
image/giffile, I get:The file is actually a valid image but its mime type is not whitelisted. In this case I propose to fall back to the original
Fileconstraint message which is better IMO:It gives more hints.