8000 [Form] Missing Data Handling (checkbox edge cases) by filiplikavcan · Pull Request #45081 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Form] Missing Data Handling (checkbox edge cases) #45081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: 7.4
Choose a base branch
from
+196 −15
Open

[Form] Missing Data Handling (checkbox edge cases) #45081

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
d47a57f
[Form] Missing Data Handling (checkbox)
filiplikavcan Jan 19, 2022
753382d
Fix failing tests (missingDataHandler was not used in HttpFoundationR…
filiplikavcan Aug 2, 2022
9da6d1c
Remove unnecessary 'use'
filiplikavcan Aug 2, 2022
82535ab
Force push
filiplikavcan Aug 2, 2022
4eb6dad
Force push
filiplikavcan Aug 2, 2022
663984e
Add original logic (has/all) back
filiplikavcan Aug 2, 2022
591b4b9
CS
filiplikavcan Aug 2, 2022
d1853fd
CS
filiplikavcan Aug 2, 2022
5a5fe0a
Handle uninitialized FormConfigBuilder::$type
filiplikavcan Aug 2, 2022
474ac30
CS
filiplikavcan Aug 2, 2022
ab3c101
Force restart tests
filiplikavcan Aug 2, 2022
5ef1388
[WIP] Rebase to 6.2
filiplikavcan Aug 3, 2022
4dcd5a4
[WIP] Code clarifications
filiplikavcan Oct 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8000
Prev Previous commit
Next Next commit
CS
  • Loading branch information
@filiplikavcan
filiplikavcan committed Oct 4, 2022
commit 474ac3062336aabe57e3341af30dcde0a094db96
5 changes: 2 additions & 3 deletions src/Symfony/Component/Form/MissingDataHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,8 @@ private function handleMissingData(FormInterface $form, mixed $data): mixed
return $data;
}
}
}
catch (\Error $error) {
if ($error->getMessage() === 'Typed property Symfony\Component\Form\FormConfigBuilder::$type must not be accessed before initialization') {
} catch (\Error $error) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Catching type errors here doesn't look like the right solution to me. We should investigate instead why the $type property in FormConfigBuilder isn't initialized at this point and fix that root issue instead.

Copy link
Contributor Author
@filiplikavcan filiplikavcan Aug 3, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like it either.

Another solution could be to make FormConfigBuilderInterface::getType() nullable. Then null state would have to be handled in these methods where getType() is called:

ValidatorDataCollector#getCasters
FormDataExtractor#extractConfiguration
FormDataCollector#getCasters
FormTypeCsrfExtension#finishView
FormTypeCsrfExtension#buildForm
BaseType#buildView
Button#createView

I don't know if null/undefined type is a valid case or not.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can look into why we run into this error here. But that will probably not happen before the weekend.

Copy link
Contributor Author
@filiplikavcan filiplikavcan Aug 3, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. When I created this PR on Jan 19 it worked. These commits look related: a53b450d 488a262a

if ('Typed property Symfony\Component\Form\FormConfigBuilder::$type must not be accessed before initialization' === $error->getMessage()) {
return $data;
}

Expand Down
0