8000 [Cache] Don't lock when doing nested computations by nicolas-grekas · Pull Request #44820 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Cache] Don't lock when doing nested computations #44820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 28, 2021
Merged

[Cache] Don't lock when doing nested computations #44820

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[Cache] Don't lock when doing nested computations
  • Loading branch information
@nicolas-grekas
nicolas-grekas committed Dec 28, 2021
commit be8cbd2aec5c99d901e611945ecfb33e569cb1c9
2 changes: 1 addition & 1 deletion src/Symfony/Component/Cache/LockRegistry.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ public static function compute(callable $callback, ItemInterface $item, bool &$s

$key = self::$files ? abs(crc32($item->getKey())) % \count(self::$files) : -1;

if ($key < 0 || (self::$lockedFiles[$key] ?? false) || !$lock = self::open($key)) {
if ($key < 0 || self::$lockedFiles || !$lock = self::open($key)) {
return $callback($item, $save);
}

Expand Down
0