10000 [HttpKernel] fix how configuring log-level and status-code by exception works by nicolas-grekas · Pull Request #44649 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[HttpKernel] fix how configuring log-level and status-code by exception works #44649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 16, 2021
Merged

[HttpKernel] fix how configuring log-level and status-code by exception works #44649

merged 1 commit into from
Dec 16, 2021

Conversation

nicolas-grekas
Copy link
Member
Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #44433
License MIT
Doc PR -

This PR replaces #44456, and essentially fixes the way configuring log-level/status-code by exception works: instead of hacking them in the listener, the original exception should be wrapped in an HttpExceptionInterface, so that the rest of the code can seamlessly know about the configuration.

@carsonbot carsonbot added this to the 5.4 milestone Dec 15, 2021
stof
stof requested changes Dec 15, 2021
View reviewed changes
yceruto
yceruto reviewed Dec 15, 2021
View reviewed changes
yceruto
yceruto reviewed Dec 15, 2021
View reviewed changes
@nicolas-grekas
Copy link
Member Author

Thanks for the feedback @yceruto. PR updated.

yceruto
yceruto approved these changes Dec 16, 2021
View reviewed changes
Copy link
Member
@yceruto yceruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to you @nicolas-grekas !

@nicolas-grekas nicolas-grekas merged commit 646c33f into symfony:5.4 Dec 16, 2021
@nicolas-grekas nicolas-grekas deleted the hk-x branch December 16, 2021 22:25
This was referenced Dec 29, 2021
Merged
Merged
@yceruto yceruto mentioned this pull request Feb 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyrixx lyrixx lyrixx approved these changes

@stof stof stof approved these changes

@yceruto yceruto yceruto approved these changes

Assignees
No one assigned
Labels
Bug HttpKernel Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
5 participants
@nicolas-grekas @lyrixx @stof @yceruto @carsonbot
0