[Routing] Support the "attribute" type (alias of "annotation") in annotation loaders #44615
Conversation
|
No strong feelings here. Please note that selecting To explain why things currently are as they are: The alternative would have been to create a separate reader for attributes. This is kind-of what Doctrine ORM did. I ultimately decided against that because I wanted people to be able to mix and match both annotation types, to allow an iterative transition from Doctrine-style annotations to attributes. Simply registering both readers on the same controllers would have made that iterative approach a bit difficult because the order in which routes are registered could matter under certain circumstances. |
73a668f to
4dce9d2 to
f309fa1
Compare
f309fa1 to
23dc924
Compare
|
@nicolas-grekas or anybody else, what do you think of this one? Looks like we are stuck with a +1 and a +0 😅 |
Minor DX feature. I migrated several projects to PHP 8 and they now use the
Routeclass as an attribute. They don't requiredoctrine/annotationsanymore. There is no PHPDoc annotations left in the code. For example, I declare the routes like this:I'd like to use
attributeas the type instead ofannotationnow because it makes more sense. Also, it's easier to explain it to newcomers.